Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert HRP to lowercase for encoding purposes #41

Merged
merged 3 commits into from Jan 3, 2020
Merged

Convert HRP to lowercase for encoding purposes #41

merged 3 commits into from Jan 3, 2020

Conversation

@clarkmoody
Copy link
Member

@clarkmoody clarkmoody commented Dec 31, 2019

Fixes #40

clarkmoody added 2 commits Dec 31, 2019
Some cargo fmt suggestions

Fixes #40
@clarkmoody clarkmoody marked this pull request as ready for review Dec 31, 2019
@clarkmoody clarkmoody requested a review from sgeisler Dec 31, 2019
src/lib.rs Outdated Show resolved Hide resolved
Copy link
Member

@sgeisler sgeisler left a comment

Looks good in general. I'd just like to avoid the extra allocation in the much more likely scenario of getting an already lowercase input.

Copy link
Member

@sgeisler sgeisler left a comment

LGTM

@clarkmoody clarkmoody merged commit ccbb003 into master Jan 3, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@clarkmoody clarkmoody deleted the issue-40 branch Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants