Add entropy bounds check #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yancyribbens
force-pushed
the
add-entropy-bounds-check
branch
from
6d8ddce to
d695cbe
Compare
stevenroose
requested changes
Jul 12, 2020
Collaborator
stevenroose
left a comment
stevenroose
left a comment
There was a problem hiding this comment.
I agree that we should check the actual length. But I'd prefer to have a single error type for bad entropy bits.
src/lib.rs
Outdated
| } | ||
|
|
||
| if (entropy.len() * 8) < 128 || (entropy.len() * 8) > 256 { | ||
| return Err(Error::BadEntropyBitLength(entropy.len() * 8)); |
Collaborator
There was a problem hiding this comment.
I think I'd prefer to use the same error type here. Right now when you get the BadEntropyBitMultiple error at first, you think using 32 or 64 bits is fine but then you'll just bump into the second error.
Contributor
Author
There was a problem hiding this comment.
@stevenroose make sense. this has been updated.
yancyribbens
force-pushed
the
add-entropy-bounds-check
branch
from
d695cbe to
123516d
Compare
yancyribbens
force-pushed
the
add-entropy-bounds-check
branch
from
123516d to
57c79a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the allowed entropy size 128-256 bits in the spec. Also added an assertion to check that the entropy is divisible by 4.