Skip to content

Add rust ci workflow #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add rust ci workflow #33

wants to merge 2 commits into from

Conversation

@notmandatory
Copy link

@notmandatory notmandatory commented Nov 10, 2022 •
edited
Loading

This adds a basic rust ci workflow following what I found in .travis.yml to run fmt, clippy and tests with different versions of rust and different features.

I allow the below clippy checks in the workflow command so everything passes with rust 1.29:

clippy:needless_range_loop
clippy::ptr_arg 
clippy::manual-range-contains

@notmandatory notmandatory force-pushed the add_test_workflow branch 6 times, most recently from e4acd65 to 986b7c7 Compare November 10, 2022 22:50
@notmandatory notmandatory marked this pull request as draft November 10, 2022 22:57
@notmandatory notmandatory force-pushed the add_test_workflow branch 9 times, most recently from 0a65d9f to 999680c Compare November 11, 2022 02:27
@notmandatory notmandatory marked this pull request as ready for review November 11, 2022 02:37
tcharding
tcharding approved these changes Nov 15, 2022
View reviewed changes
Copy link
Member

@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 999680c

Nice trick putting the features in a job matrix.

@notmandatory
Copy link
Author

notmandatory commented Feb 23, 2023

I've rebased my branch, no other changes. Once this is merged I'd be happy to add another PR to also test the zerioze feature with rust 1.51.

@notmandatory
Copy link
Author

notmandatory commented Feb 23, 2023

I just noticed there's already a github actions PR #27. Feel free to close this PR in favor of that one.

@tcharding
Copy link
Member

tcharding commented Feb 23, 2023

And now there is #42 as well :)

@notmandatory
Copy link
Author

notmandatory commented Feb 23, 2023

Closing so we have n-1 open CI PRs. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tcharding tcharding tcharding approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@notmandatory @tcharding