Skip to content

Conversation

@stevenroose
Copy link
Collaborator

No description provided.

Excluding the language files
@sgeisler
Copy link

  • Does 727a9a7 actually improve anything or is it just a question of taste? I personally prefer the languages/mod.rs version and so does rust 1.29.0.
  • Applying rustfmt project-wide should always be followed by adding a rustfmt check to CI imo, so that it doesn't diverge again over time (this is assuming that rustfmt is somewhat stable and won't break builds every second week).

@stevenroose
Copy link
Collaborator Author

Oh, well 727a9a7 made it easy to git checkout src/languages/* after doing cargo fmt because Rust 1.29 also doesn't support adding rustfmt skip tags to the language files.

The language files are also what prevents a CI check mostly. I'd hold off of having a CI check until there's no more manual fiddling required to get things right. Now it was mostly because a bunch of copy-pasted code from other places made for mixed indentation.

I'll take out 727a9a7.

Copy link

@sgeisler sgeisler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh well, the joy of supporting old rust versions 😬 but if we can't do better so be it …

@stevenroose stevenroose merged commit 1cc986e into master Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants