Remove unused "bitcoinconsenus" feature. #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also I've updated the feature name on the README.md, and fixed a typo in src/blockdata/script.rs Signed-off-by: Jean Pierre Dudey <jeandudey@hotmail.com>
|
lol |
|
cc @TheBlueMatt can you confirm that this renamed-with-a-typo feature isn't used by anything? |
apoelstra
approved these changes
Aug 15, 2018
Davidson-Souza
pushed a commit
to Davidson-Souza/rust-bitcoin
that referenced
this pull request
Jul 12, 2023
c73eb2f Use 'extra' instead of 'cheap' (Tobin Harding) c79eb97 Remove unnecessary explanation (Tobin Harding) f95e91a Use isn't instead of shouldn't (Tobin Harding) c9e6ca1 Use rust-bitcoin module doc style (Tobin Harding) 3fa6762 Add link to referenced commit (Tobin Harding) f5e68f3 Add ticks around code snippet (Tobin Harding) d25431c Use 3rd person tense for function docs (Tobin Harding) c3be285 Fix size constant docs (Tobin Harding) 5e07e75 Add period to sentences (Tobin Harding) 269bde0 Remove unnecessary capitalisation (Tobin Harding) Pull request description: In a continued effort to find my feet around here, and inspired by issue rust-bitcoin#128 I've done a codebase wide audit of the docs (primarily just rustdocs but I glanced at `//` docs as well). Each change is in a separate commit so can be removed if resistance is met. (_"resistance is futile"_). I've based the stylistic decisions on [work done](rust-bitcoin#704) in rust-bitcoin. I believe the only controversial change is the last (commit: da161c9 Use rust-bitcoin module doc style), please review that one carefully. ACKs for top commit: apoelstra: ACK c73eb2f Tree-SHA512: 5ea215de3fd23ca2a4f25d8f8d59a85a299044fe495269c43b621291ea50c58856fa8544e36cc109b7bdb1a7a59bcab8711f30113572ddce4509d3b06ff0d3b6
Davidson-Souza
pushed a commit
to Davidson-Souza/rust-bitcoin
that referenced
this pull request
Jul 12, 2023
ecdad39 context: Improve rustdocs (Tobin C. Harding) e945751 schnorr: Improve rustdocs (Tobin C. Harding) 47f19a7 Use lowercase for schnorr (Tobin C. Harding) 27b3e92 Do trivial cleanup to module level docs (Tobin C. Harding) Pull request description: Audit of docs in `rust-secp256k1` and do a few trivial fixes. The docs are in pretty good condition, they just need more content as described in rust-bitcoin#128 if that issue is still valid. ACKs for top commit: apoelstra: ACK ecdad39 Tree-SHA512: 7466090325e02331f11e34cd38625541fbe8e642882afa6ddf2cf5d11ed669c7b2b48fd5b819915392760f4c6ef4ee460c2e622b3af648f99906c3ac408045d4
casey
pushed a commit
to casey/rust-bitcoin
that referenced
this pull request
Nov 28, 2023
Add scantxoutset
yancyribbens
pushed a commit
to yancyribbens/rust-bitcoin
that referenced
this pull request
Mar 23, 2024
yancyribbens
pushed a commit
to yancyribbens/rust-bitcoin
that referenced
this pull request
Mar 23, 2024
360eed7 Add some compiler documentation (sanket1729) Pull request description: Fixes rust-bitcoin#128 ACKs for top commit: apoelstra: ACK 360eed7 Tree-SHA512: 70f544962ac824d0355d091d1c1dfc81b2e9f0d3896402c12911bae1e13b80b19fc90b43c5ad4a49d8c15e7edf6d6a6b543cdab915a003f0ae9be807f02dcbbf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.