New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bip32::parse_derivation_path #185

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@stevenroose
Contributor

stevenroose commented Nov 1, 2018

Utility method to parse a m/0'/0'/0-like path.

Harden characters ' and h are supported.

stevenroose added some commits Nov 1, 2018

Add bip32::parse_derivation_path
This public method parses a formatted derivation path into a
`Vec<ChildNumber>`.
@clarkmoody

This comment has been minimized.

Member

clarkmoody commented Nov 5, 2018

Concept ACK.

Fuzz testing is failing in the CI build. I'm not sure what to do about that.

@stevenroose

This comment has been minimized.

Contributor

stevenroose commented Nov 6, 2018

Hmm, it fails to build a fuzzing dep. I have no idea about the fuzzing setup in rust-bitcoin, bth.

fn from_str(inp: &str) -> Result<ChildNumber, Error> {
let mut hardened = false;
let last = inp.chars().last();

This comment has been minimized.

@stevenroose

stevenroose Nov 6, 2018

Contributor

Perhaps .chars().rev().nth(0) is more efficient.. Not sure how that is done internally.

This comment has been minimized.

@stevenroose
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment