Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump bitcoin-bech32 dependency #244

Merged
merged 1 commit into from Mar 7, 2019

Conversation

Projects
None yet
3 participants
@stevenroose
Copy link
Collaborator

stevenroose commented Mar 4, 2019

This makes the Address::Payload::WitnessProgram inner type compatiblewith rust-lightning-invoice's Fallback::SegWitProgram's inner type.
This allows specifying fallbacks from addresses.

@stevenroose stevenroose requested a review from sgeisler Mar 4, 2019

Bump bitcoin-bech32 dependency
This makes the Address::Payload::WitnessProgram inner type compatible
with rust-lightning-invoice's Fallback::SegWitProgram's inner type.
This allows specifying fallbacks from addresses.

@sgeisler sgeisler added the API break label Mar 6, 2019

@sgeisler
Copy link
Member

sgeisler left a comment

Sounds like a good idea, I hope that the types will converge more over time, but I have to plan how to do that without having too much duplicated data ("cached" bech32 representation).

@dongcarl dongcarl merged commit d667e0f into rust-bitcoin:master Mar 7, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.