Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanity checks for vector length #25

Merged
merged 2 commits into from Jun 7, 2017

Conversation

Projects
None yet
3 participants
@neosilky
Copy link
Contributor

commented Jun 5, 2017

Found a couple of panics using cargo-fuzz which are fixed by the following changes.

@apoelstra

This comment has been minimized.

Copy link
Member

commented Jun 6, 2017

Cool, thanks! Can you also commit the fuzzing support code?

@neosilky

This comment has been minimized.

Copy link
Contributor Author

commented Jun 7, 2017

Hi @apoelstra! I've added the fuzzing code - there are a few things to fuzz so I've tried to make it as simple as possible.

@Kixunil

This comment has been minimized.

Copy link

commented Jun 7, 2017

@neosilky Is there some online corpus of blockchain data?

@neosilky

This comment has been minimized.

Copy link
Contributor Author

commented Jun 7, 2017

@Kixunil I'm not actually sure. I just let cargo-fuzz run and generate its own corpus.

@apoelstra

This comment has been minimized.

Copy link
Member

commented Jun 7, 2017

Great, thanks!

I need to generate an offending input and add a unit test, then I'll accept this. (Or if you could do this, that would be great.)

@apoelstra

This comment has been minimized.

Copy link
Member

commented Jun 7, 2017

ACK

@apoelstra apoelstra merged commit 287d285 into rust-bitcoin:master Jun 7, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Kixunil

This comment has been minimized.

Copy link

commented Jun 7, 2017

@neosilky AFAIK using corpus based on existing known good data is very efficient. I've read somewhere that Google is building large corpus of different file formats etc.

I'd be nice to do this for Bitcoin too.

@neosilky neosilky deleted the neosilky:panic-fix branch Jun 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.