Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .rustfmt.toml and .editorconfig and format all files #290

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@stevenroose
Copy link
Collaborator

commented Jul 6, 2019

Fixes #172.

@apoelstra
Copy link
Member

left a comment

Not thrilled with everything but overall it's much more consistent and less likely that future PRs will need to do formatting changes to surrounding code.

@sgeisler
Copy link
Member

left a comment

Maybe we should also add instructions to the README.md so people aren't too surprised if their PRs fail on travis due to formatting?

@apoelstra

This comment has been minimized.

Copy link
Member

commented Jul 6, 2019

  1. You need to add rustup component install cargo-fmt or something before cargo fmt in the test script.
  2. I'd like to hold off on merging this til the other pending big PRs get in, because it's easier to rebase this than to rebase non-mechanical code changes.

@stevenroose stevenroose dismissed stale reviews from sgeisler and apoelstra via c70dcb7 Jul 6, 2019

@stevenroose stevenroose force-pushed the stevenroose:rustfmt branch 3 times, most recently from a79d4ba to 4232307 Jul 6, 2019

@stevenroose stevenroose force-pushed the stevenroose:rustfmt branch from 4232307 to 7f58ab9 Jul 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.