Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRIVIAL] enable serde serialization for block and blockheader #321

Merged
merged 1 commit into from Sep 5, 2019

Conversation

@tamasblummer
Copy link
Member

commented Aug 24, 2019

Transaction is already also serde serializable. The same is desirable for block and blockheader since extensions to consensus encoding are no longer possible outside this crate. serde encoded objects might contain block and blockheader not only transactions.

@tamasblummer tamasblummer changed the title enable serde serialization for block and blockheader [TRIVIAL] enable serde serialization for block and blockheader Aug 24, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Aug 24, 2019

Codecov Report

Merging #321 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #321      +/-   ##
==========================================
+ Coverage   81.93%   81.98%   +0.04%     
==========================================
  Files          38       38              
  Lines        6982     6998      +16     
==========================================
+ Hits         5721     5737      +16     
  Misses       1261     1261
Impacted Files Coverage Δ
src/blockdata/block.rs 73.82% <ø> (+3.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24361dd...38d5ae4. Read the comment docs.

@apoelstra
Copy link
Member

left a comment

Nice. Looks like an oversight.

@stevenroose stevenroose merged commit de9ccde into rust-bitcoin:master Sep 5, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.