Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump version to 0.18.1; semver-trick scripts and keys #325

Merged

Conversation

@apoelstra
Copy link
Member

commented Sep 4, 2019

[DO NOT MERGE]

This branch represents a proposal for 0.18.1 which semver-tricks 0.18 into having the same keys and scripts as 0.19, which should make upgrading a little less painful.

Unfortunately we cannot update any of the transaction or block structures, which would be the most useful, since they all eventually depend on OutPoint which depends on bitcoin_hashes::sha256d::Hash which was replaced in the 0.18→0.19 transition.

This commit also changes the Display output of NOP2 and NOP3 to CLTV and CSV, which is arguably a breaking change, but I think it is acceptable.

CI will fail because of dtolnay/semver-trick#4 ... it shouldn't fail for any other reason.

@apoelstra apoelstra force-pushed the apoelstra:2019-09-semver-trick-0.18.1 branch from 730cd74 to 14f7f19 Sep 4, 2019

@apoelstra apoelstra changed the base branch from master to backport-0.18 Sep 4, 2019

@apoelstra

This comment has been minimized.

Copy link
Member Author

commented Sep 4, 2019

also got a concept ACK (at least, an "in principle ok" with some grumbling about program size) from matt on IRC

@apoelstra apoelstra merged commit 418beab into rust-bitcoin:backport-0.18 Sep 4, 2019

@apoelstra apoelstra deleted the apoelstra:2019-09-semver-trick-0.18.1 branch Sep 4, 2019

@apoelstra

This comment has been minimized.

Copy link
Member Author

commented Sep 4, 2019

PublicKey::from_slice returns a Result<_, consensus::encode::Error>, which we cannot re-export. So this is actually a breaking change and there isn't any good way to recover. Going to need to revert this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.