Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme: Add links to CHANGELOG.md and LICENSE #378

Merged
merged 1 commit into from Jan 24, 2020

Conversation

@wbnns
Copy link
Contributor

wbnns commented Jan 6, 2020

For convenience, added links to the CHANGELOG.md and LICENSE that are referenced in README.md.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 6, 2020

Codecov Report

Merging #378 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #378   +/-   ##
=======================================
  Coverage   85.45%   85.45%           
=======================================
  Files          40       40           
  Lines        8629     8629           
=======================================
  Hits         7374     7374           
  Misses       1255     1255

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50f3a60...d01cce7. Read the comment docs.

Copy link
Member

dongcarl left a comment

Hi Will :-)
We could probably use relative links to ensure that even if the user is browsing a branch the link resolves properly.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@stevenroose

This comment has been minimized.

Copy link
Collaborator

stevenroose commented Jan 23, 2020

+1 for relative links

@wbnns wbnns force-pushed the wbnns:readme-links branch from d01cce7 to 410e45f Jan 23, 2020
@wbnns

This comment has been minimized.

Copy link
Contributor Author

wbnns commented Jan 23, 2020

Thanks! Done (410e45f).

@wbnns wbnns requested review from dongcarl and stevenroose Jan 23, 2020
Copy link
Collaborator

elichai left a comment

ACK

@elichai

This comment has been minimized.

Copy link
Collaborator

elichai commented Jan 23, 2020

FYI CI failures are because of #398

@stevenroose

This comment has been minimized.

Copy link
Collaborator

stevenroose commented Jan 23, 2020

Yeah let's get #398 in asap :)

Copy link
Member

apoelstra left a comment

dope

@apoelstra apoelstra dismissed dongcarl’s stale review Jan 24, 2020

changes addressed

@apoelstra apoelstra merged commit 1b946b0 into rust-bitcoin:master Jan 24, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.