Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.23.0 #380

Merged
merged 2 commits into from Jan 9, 2020
Merged

Release v0.23.0 #380

merged 2 commits into from Jan 9, 2020

Conversation

@stevenroose
Copy link
Collaborator

stevenroose commented Jan 7, 2020

No description provided.

@stevenroose

This comment has been minimized.

Copy link
Collaborator Author

stevenroose commented Jan 9, 2020

error[E0432]: unresolved import `secp256k1::rand::thread_rng`

   --> src/util/contracthash.rs:288:9

    |

288 |     use secp256k1::rand::thread_rng;

    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^ no `thread_rng` in `rand`

error[E0425]: cannot find function `thread_rng` in this scope

   --> src/util/merkleblock.rs:511:23

    |

511 |         let mut rng = thread_rng();

    |                       ^^^^^^^^^^ not found in this scope

error[E0412]: cannot find type `ThreadRng` in this scope

   --> src/util/merkleblock.rs:699:40

    |

699 |         fn damage(&mut self, rng: &mut ThreadRng) {

    |                                        ^^^^^^^^^ not found in this scope

error: unused import: `secp256k1::rand::prelude`

   --> src/util/merkleblock.rs:502:9

    |

502 |     use secp256k1::rand::prelude::*;

    |         ^^^^^^^^^^^^^^^^^^^^^^^^

    |

note: lint level defined here

   --> src/lib.rs:44:9

    |

44  | #![deny(unused_imports)]

    |         ^^^^^^^^^^^^^^

error: aborting due to 4 previous errors

Did rand publish a minor version and took out thread_rng? I can't believe that..

@dr-orlovsky

This comment has been minimized.

Copy link
Contributor

dr-orlovsky commented Jan 9, 2020

Very strange, I was using it yesterday evening and it was still there with the latest release

@elichai elichai mentioned this pull request Jan 9, 2020
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 9, 2020

Codecov Report

Merging #380 into master will decrease coverage by 0.65%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #380      +/-   ##
==========================================
- Coverage   85.55%   84.89%   -0.66%     
==========================================
  Files          40       40              
  Lines        8660     7278    -1382     
==========================================
- Hits         7409     6179    -1230     
+ Misses       1251     1099     -152
Impacted Files Coverage Δ
src/network/message_blockdata.rs 89.23% <0%> (-3.7%) ⬇️
src/blockdata/block.rs 78.83% <0%> (-1.59%) ⬇️
src/util/contracthash.rs 78.5% <0%> (-1.29%) ⬇️
src/blockdata/script.rs 78.59% <0%> (-1.18%) ⬇️
src/blockdata/transaction.rs 93.92% <0%> (-0.94%) ⬇️
src/util/hash.rs 93.75% <0%> (-0.85%) ⬇️
src/util/bip32.rs 87.14% <0%> (-0.83%) ⬇️
src/consensus/encode.rs 85.15% <0%> (-0.44%) ⬇️
src/network/address.rs 98.82% <0%> (-0.22%) ⬇️
src/network/message_filter.rs 100% <0%> (ø) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7587c4b...2326dd6. Read the comment docs.

@elichai
elichai approved these changes Jan 9, 2020
Copy link
Collaborator

elichai left a comment

Finally :)

@apoelstra apoelstra merged commit 2cba819 into rust-bitcoin:master Jan 9, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@clarkmoody clarkmoody mentioned this pull request Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.