Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile libsecp256k1 ourselves #13

Merged
merged 5 commits into from Jan 8, 2020
Merged

Conversation

@elichai
Copy link
Contributor

elichai commented Jan 7, 2020

Hi,
as talked on IRC, this removes rust-secp256k1 as a dependency and compiles libsecp by it self.

elichai added 3 commits Jan 7, 2020
.opt_level(2)
.debug(true)
Comment on lines -11 to -12

This comment has been minimized.

Copy link
@elichai

elichai Jan 7, 2020

Author Contributor

Removed these because the cc crate autodetects this and passes the same debug/release and opt level as rust got
rust-bitcoin/rust-secp256k1#166

elichai added 2 commits Jan 7, 2020
@elichai elichai force-pushed the elichai:2020-01-depend branch from d997434 to 6c5cc47 Jan 7, 2020
@elichai elichai mentioned this pull request Jan 7, 2020
@elichai

This comment has been minimized.

Copy link
Contributor Author

elichai commented Jan 7, 2020

I can't add reviewers here, so would appreciate a review from either @apoelstra @TheBlueMatt
(and on the related #14)

@stevenroose

This comment has been minimized.

Copy link
Collaborator

stevenroose commented Jan 7, 2020

ACK 6c5cc47

@stevenroose stevenroose merged commit 6c5cc47 into rust-bitcoin:master Jan 8, 2020
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@elichai elichai deleted the elichai:2020-01-depend branch Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.