New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.2 release fixes #11

Merged
merged 1 commit into from Feb 11, 2019

Conversation

Projects
None yet
2 participants
@dpc
Copy link
Collaborator

dpc commented Feb 1, 2019

No description provided.

@dpc dpc requested a review from stevenroose Feb 1, 2019

@@ -18,7 +18,7 @@ name = "bitcoincore_rpc"
path = "src/lib.rs"

[dependencies]
bitcoincore-rpc-json = "0.2"
bitcoincore-rpc-json = { version = "0.2", path = "../json" }

This comment has been minimized.

@stevenroose

stevenroose Feb 1, 2019

Collaborator

This doesn't work for releasing.

This comment has been minimized.

@dpc

This comment has been minimized.

@stevenroose

stevenroose Feb 1, 2019

Collaborator

So how do you release? Last time I tried to cargo publish a crate with a path = dependency, I got a message telling me that path dependencies are not allowed or something.

This comment has been minimized.

@dpc

dpc Feb 2, 2019

Author Collaborator

It just works. Always worked. :) You first release the json, then you go to the client and release that. path is ignored when doing cargo publish, AFAIK.

Show resolved Hide resolved .travis.yml Outdated

@dpc dpc force-pushed the dpc:0.2-release-fixes branch from 7918815 to 36d9757 Feb 1, 2019

@dpc

This comment has been minimized.

Copy link
Collaborator Author

dpc commented Feb 1, 2019

Rebased.

@stevenroose

This comment has been minimized.

Copy link
Collaborator

stevenroose commented Feb 2, 2019

@dpc

This comment has been minimized.

Copy link
Collaborator Author

dpc commented Feb 5, 2019

🚀 land&publish 🚀 ? :D

@dpc

This comment has been minimized.

Copy link
Collaborator Author

dpc commented Feb 7, 2019

ship it ?

@stevenroose stevenroose merged commit 39c438a into rust-bitcoin:master Feb 11, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment