Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump crate version to v0.17.0 #253

Merged
merged 2 commits into from
Apr 9, 2023
Merged

Bump crate version to v0.17.0 #253

merged 2 commits into from
Apr 9, 2023

Conversation

tcharding
Copy link
Member

@tcharding tcharding commented Oct 28, 2022 •
edited
Loading

Add release notes and increase the crate minor version to 0.17.0

Justified because we just bumped the rust-jsonrpc minor version.

  • Patch 1 updates rust-jsonrpc dependency to current version
  • Patch 2 does the release

@tcharding tcharding mentioned this pull request Oct 28, 2022
Merged
@Kixunil Kixunil mentioned this pull request Nov 5, 2022
Closed
@romanz romanz mentioned this pull request Nov 6, 2022
Merged
@Kixunil
Copy link

Kixunil commented Nov 6, 2022

Looks like this crate needs more love... :(

@romanz
Copy link
Contributor

romanz commented Nov 19, 2022

Ping @stevenroose :)

@schildbach
Copy link

Any plans on merging this? IPv6 support is needed in the projects downstream.

@apoelstra
Copy link
Member

@tcharding can you bump the rust-jsonrpc version to 0.14.0

@tcharding
Copy link
Member Author

Sure can, no sweat.

@tcharding
Update jsonrpc dependency to v0.14.0
c7a88d1 
Bump our `jsonrpc` dependency to the latest version v0.14.0
@tcharding
Bump crate version to 0.17.0
37786d3 
Add release notes and increase the crate minor version to 0.17.0

Justified because we just bumped the `rust-bitcoin` minor version and
also `rust-jsonrpc` minor version.
@tcharding
Copy link
Member Author

I've removed what was patch 1 of this PR, which while valid, displayed a lack of understanding of how cargo resolves dependencies and is basically unnecessary :) rust-bitcoin latest version is 0.29.0 and cargo will build with the latest point release 0.29.2 - face palm.

@apoelstra apoelstra mentioned this pull request Dec 3, 2022
Closed
@tcharding
Copy link
Member Author

@stevenroose can you release this please bro? @apoelstra do you have perms to do the release if Steven doesn't get to it?

@apoelstra
Copy link
Member

It looks like no, I do not.

@apoelstra apoelstra mentioned this pull request Dec 20, 2022
Closed
@benma
Copy link
Contributor

benma commented Dec 22, 2022

@stevenroose please also include this in the 0.17.0 release:

6c4cd8a

Also, when release? 😄

@romanz romanz mentioned this pull request Jan 6, 2023
Closed
w0xlt
w0xlt approved these changes Jan 29, 2023
View reviewed changes
Copy link

@w0xlt w0xlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 37786d3

@Kixunil Kixunil mentioned this pull request Mar 9, 2023
Closed
@stevenroose
Copy link
Collaborator

Sorry for my inactivity lately! I'll merge and release this right now :)

@stevenroose stevenroose merged commit bf153d6 into rust-bitcoin:master Apr 9, 2023
@Kixunil
Copy link

Kixunil commented Apr 9, 2023

Would you please consider adding someone as a co-maintainer so that releases are not blocked by your time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@w0xlt w0xlt w0xlt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@tcharding @Kixunil @romanz @schildbach @apoelstra @benma @stevenroose @w0xlt