Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make fields optional in GetRawTransactionResult #26

Merged
merged 1 commit into from Apr 1, 2019

Conversation

Projects
None yet
2 participants
@nkostoulas
Copy link
Contributor

nkostoulas commented Mar 20, 2019

Block fields are optional in bitcoin core. If this rpc is used for a transaction that has not been included in a block then it will fail.

@stevenroose

This comment has been minimized.

Copy link
Collaborator

stevenroose commented Apr 1, 2019

Whoops, didn't see this PR in time. I think it's superceded by #28.

But thanks for the contribution! Please let me know if #28 doesn't fix this.

@stevenroose

This comment has been minimized.

Copy link
Collaborator

stevenroose commented Apr 1, 2019

Hmm, seems like those extra 2 fields are also optional. Will merge this and rebase #28.

@stevenroose
Copy link
Collaborator

stevenroose left a comment

Thanks

@stevenroose stevenroose merged commit 6d3817b into rust-bitcoin:master Apr 1, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.