Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the getter traits #32

Merged
merged 1 commit into from Apr 1, 2019

Conversation

Projects
None yet
2 participants
@stevenroose
Copy link
Collaborator

stevenroose commented Apr 1, 2019

I don't remember who suggested them, but I don't see value for them.
They require an additional import from the user and separate the impl
from the type which is confusing.

@stevenroose stevenroose added this to the v0.3.0 milestone Apr 1, 2019

@stevenroose stevenroose requested review from dpc and sgeisler Apr 1, 2019

@stevenroose stevenroose force-pushed the stevenroose:no-getters branch from ad3c582 to 1504aba Apr 1, 2019

Remove the getter traits
I don't remember who suggested them, but I don't see value for them.
They require an additional import from the user and separate the impl
from the type which is confusing.
@dpc

dpc approved these changes Apr 1, 2019

@stevenroose stevenroose merged commit 6a3be8c into rust-bitcoin:master Apr 1, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.