Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various improvements #34

Merged
merged 11 commits into from Apr 7, 2019

Conversation

Projects
None yet
2 participants
@stevenroose
Copy link
Collaborator

stevenroose commented Apr 6, 2019

Sorry to put so many changes together, but they are grouped in small commits and too many to open PRs for all of them.

I want to make a new release ASAP because get_tx_out is really broken currently and relies on new jsonrpc version to be fixed.

@stevenroose stevenroose requested a review from dpc Apr 6, 2019

@stevenroose stevenroose force-pushed the stevenroose:improvements branch from 18734d9 to 6b10e3c Apr 6, 2019

@stevenroose stevenroose referenced this pull request Apr 6, 2019

Open

[WIP] Fix listunspent #35

stevenroose added some commits Apr 6, 2019

Fix gettxout
gettxout is a rare call since it doesn't return an error when the
queried information is not found, but instead a null return.
@@ -405,20 +416,17 @@ pub trait RpcApi: Sized {
signature: &Signature,
message: &str,
) -> Result<bool> {
let args = [into_json(address)?, into_json(signature)?, into_json(message)?];
let args = [address.to_string().into(), signature.to_string().into(), into_json(message)?];

This comment has been minimized.

Copy link
@dpc

dpc Apr 7, 2019

Collaborator

Does this pattern means allocating twice?

This comment has been minimized.

Copy link
@stevenroose

stevenroose Apr 7, 2019

Author Collaborator

I'm not sure. Shouldn't be. I think From<String> for Value should not re-allocate.

@dpc

dpc approved these changes Apr 7, 2019

stevenroose added some commits Apr 7, 2019

@stevenroose stevenroose merged commit eb2d7e5 into rust-bitcoin:master Apr 7, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stevenroose stevenroose deleted the stevenroose:improvements branch Apr 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.