Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fundrawtransaction command, fix signing commands #37

Merged
merged 5 commits into from Apr 12, 2019

Conversation

Projects
None yet
2 participants
@stevenroose
Copy link
Collaborator

stevenroose commented Apr 11, 2019

If this is merged, I will release v0.5.0, since this breaks existing interface.

@stevenroose stevenroose requested a review from dpc Apr 11, 2019

@stevenroose stevenroose force-pushed the stevenroose:fundrawtx branch from cf485f3 to d7dc66c Apr 11, 2019

@stevenroose stevenroose changed the title Add fundrawtransaction command Add fundrawtransaction command, fix signrawtransactionwithwallet Apr 11, 2019

@stevenroose stevenroose changed the title Add fundrawtransaction command, fix signrawtransactionwithwallet Add fundrawtransaction command, fix signing commands Apr 11, 2019

@stevenroose stevenroose force-pushed the stevenroose:fundrawtx branch from 2bb72a2 to ae3904b Apr 11, 2019

@dpc

dpc approved these changes Apr 11, 2019

@@ -57,6 +57,16 @@ fn null() -> serde_json::Value {
serde_json::Value::Null
}

/// Shorthand for an empty serde_json::Value array.
fn empty() -> serde_json::Value {

This comment has been minimized.

Copy link
@dpc

dpc Apr 11, 2019

Collaborator

empty_arr or empty_vec?

@stevenroose

This comment has been minimized.

Copy link
Collaborator Author

stevenroose commented Apr 12, 2019

You're right :D I just copied this from liquid-rpc where empty_obj didn't exist yet. I'll change it to empty_arr.

@stevenroose stevenroose force-pushed the stevenroose:fundrawtx branch from ae3904b to c268b7e Apr 12, 2019

@dpc

This comment has been minimized.

Copy link
Collaborator

dpc commented Apr 12, 2019

LGTM. We should eventually work on the test_against_node.rs or something like this, to be able to run it in travis against regtest node, and see if all the calls are still working. Nothing fancy, just some sanity.

@stevenroose

This comment has been minimized.

Copy link
Collaborator Author

stevenroose commented Apr 12, 2019

Yeah totally agree. There is an issue for this too.

@stevenroose stevenroose merged commit 04176c0 into rust-bitcoin:master Apr 12, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.