Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return unwrapped types from Invoice getters #27

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@sgeisler
Copy link
Member

sgeisler commented Mar 1, 2019

Fixes #26. Since Invoice is part of the high level API it makes sense to not bother the user with the internal newtypes. To mirror InvoiceBuilder this PR removes the wrapping where possible.

@sgeisler

This comment has been minimized.

Copy link
Member Author

sgeisler commented Mar 1, 2019

@stevenroose Would this PR help you with #23 ?

@stevenroose

This comment has been minimized.

Copy link

stevenroose commented Mar 1, 2019

Surely would!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.