-
Notifications
You must be signed in to change notification settings - Fork 283
Make test.sh test and build secp256k1-sys #256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Damn it. of course 1.29 doesn't have the |
concept ACK. I'm surprised you need |
It sounds like you're right, but for some reason I don't see those tests running without
https://www.mankier.com/1/cargo-test#Options-Package_Selection I'll try to find time to look into it and maybe open/find a cargo bug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ack d95cb53
Just kidding. Needs rebase. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ack 21f231b
Cool find with this VERBOSE variable.
There are currently 2 tests in secp256k1-sys and our CI doesn't run them.
This fixes that, but instead of adding another section to tests.sh I added
secp256k1-sys
to the workspace and made the builds and tests run on the whole workspace.I had to exclude
no_std_test
from the workspace because it only works on nightly.I also fixed a bug where if you pass both
DO_ASAN=true
andDO_BENCH=true
it will try to do the benchmarks onno_std_test