Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parity conversion and error handling cleanup #403

Merged
merged 1 commit into from
Mar 1, 2022

Conversation

Kixunil
Copy link
Collaborator

@Kixunil Kixunil commented Feb 10, 2022

This removes the deprecated From conversion, replaces it with
TryFrom, and adds more convenience conversions. A new error type is
created for the invalid parity error with conversion to catch-all
Error.

This is intended for an API-breaking version.

@tcharding
Copy link
Member

TryFrom isn't available until Rust 1.34

@Kixunil
Copy link
Collaborator Author

Kixunil commented Feb 11, 2022

Aren't we doing ecosystem-wide MSRV bump to 1.41.1?

@tcharding
Copy link
Member

tcharding commented Feb 11, 2022

Sure thing. Perhaps we could have a label for 'will work once we bump MSRV' to help us queue these changes up and to save others checking what the CI fail is about?

@Kixunil
Copy link
Collaborator Author

Kixunil commented Feb 24, 2022

Spurious CI error

@apoelstra apoelstra closed this Feb 28, 2022
@apoelstra apoelstra reopened this Feb 28, 2022
@apoelstra
Copy link
Member

Looks like CI is working again -- but PR still needs update if we're going to get it into this major version (which does not increase MSRV)

@apoelstra
Copy link
Member

ACK cf6badf aside from the source stuff (or whatever it is that is breaking 1.29)

This removes the deprecated `From` conversion and adds a new error
type for the invalid parity error with a conversion to the catch-all
`Error`.
@Kixunil
Copy link
Collaborator Author

Kixunil commented Feb 28, 2022

Fixed (changed to cause())

Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 5acf6d2

@apoelstra apoelstra merged commit dc90a43 into rust-bitcoin:master Mar 1, 2022
@Kixunil Kixunil deleted the parity-error-handling branch March 1, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants