Fix test failure #169
Merged
Fix test failure #169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported in
hjson/hjson-rust#23
the issue of the failing tests is the serde_hjson crate. The problem can
be prevented (as reported by
hjson/hjson-rust#23 (comment)) by
disabling the default features of the crate (namingly preservation of
key order).
This commit disables the default features of serde_hjson to fix our
tests.
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Member
Author
|
This is merged in config-rs-maint and released in version 0.11.0. |
This was referenced Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in
the issue of the failing tests is the serde_hjson crate. The problem can
be prevented (as reported by
hjson/hjson-rust#23 (comment)) by
disabling the default features of the crate (namingly preservation of
key order).
This commit disables the default features of serde_hjson to fix our
tests.
--
Closes #158