Rename get_str() → get_string() to match returned type #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, thanks! I'd take this patch as is, but please remove the CHANGELOG entry from the commit. I will take care of writing the changelog myself right before the release - that's just the way I prefer to do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #140.
I couldn't find any good reason to make this return
&strinstead, the handling everywhere else is asStringso just renaming the function to match what it already does seemed most logical thing to do.This will be a breaking change to the API, but the fix will be easy. All instances of
Config.get_str()need to be changed toConfig.get_string(). The returned value being handled in people's code is alreadyString.