Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify source position #159

Merged
merged 1 commit into from Dec 8, 2019
Merged

Clarify source position #159

merged 1 commit into from Dec 8, 2019

Conversation

@mkesper
Copy link

mkesper commented Nov 25, 2019

Make it clear source is edited in src/main.rs and where source parts are positioned.
Help newbies by claryfying this.

Michael Kesper
Make it clear source is edited in src/main.rs and where source parts are positioned.
Help newbies by claryfying this.
@Dylan-DPC

This comment has been minimized.

Copy link
Member

Dylan-DPC commented Nov 25, 2019

Thanks

@mkesper

This comment has been minimized.

Copy link
Author

mkesper commented Nov 25, 2019

Thanks for the fast response!

I'm also not sure whether
#![allow(unused)]
should be used to suppress the warnings on first runs.

@spacekookie

This comment has been minimized.

Copy link
Collaborator

spacekookie commented Dec 6, 2019

Thanks for the fast response!

I'm also not sure whether
#![allow(unused)]
should be used to suppress the warnings on first runs.

I feel that that's on okay trade-off to make

@spacekookie spacekookie merged commit 5de6d54 into rust-cli:master Dec 8, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.