Skip to content

Bump dependencies and make things compile #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Bump dependencies and make things compile #19

wants to merge 1 commit into from

Conversation

@dflemstr
Copy link
Contributor

@dflemstr dflemstr commented Nov 9, 2019

I'd like someone to throw an eye at the MaybeUninit code. I'm not sure if it's safe to hand out a slice and transmute it the way I did

@japaric japaric mentioned this pull request Nov 17, 2019
Merged
bors bot added a commit that referenced this pull request Nov 17, 2019
@bors @japaric
Merge #20
7c1734d 
20: fix warnings; bump heapless; add crate status r=japaric a=japaric

closes #19

Co-authored-by: Jorge Aparicio <jorge@japaric.io>
@bors bors bot closed this in #20 Nov 17, 2019
@bors bors bot closed this in 0f0fe3b Nov 17, 2019
@japaric
Copy link
Collaborator

japaric commented Nov 17, 2019

Thanks for the PR but I decided to continue using mem::uninitialized because it's equivalent to MaybeUninit::uninit().assume_init() but doesn't raise the MSRV (Minimal Supported Rust Version) from 1.31 to 1.36.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dflemstr @japaric