Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upFill in social media links for post 11 #14
Conversation
jamesmunns
requested a review
from rust-embedded/resources
as a
code owner
Sep 10, 2018
This comment has been minimized.
This comment has been minimized.
|
Please feel free to "bors r+" whenever this whenever it is reviewed. |
This comment has been minimized.
This comment has been minimized.
|
Also fixes the missing link found by @adamgreen |
This comment has been minimized.
This comment has been minimized.
|
Hey @rust-embedded/resources, if anyone could give this a quick review, it would be appreciated :) |
bors bot
added a commit
that referenced
this pull request
Sep 10, 2018
This comment has been minimized.
This comment has been minimized.
Build succeeded |
bors
bot
merged commit f6eb1af
into
master
Sep 10, 2018
bors
bot
deleted the
fix-11-links
branch
Sep 10, 2018
This comment has been minimized.
This comment has been minimized.
|
Thank you @japaric! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
jamesmunns commentedSep 10, 2018
Fixing links (and indirectly, the broken render) for social media.
Note to future self: Gutenberg doesn't like "null" links.