This repository has been archived by the owner on Jan 24, 2022. It is now read-only.
[RFC] rename UserHardFault to HardFault #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therealprof
previously approved these changes
Oct 27, 2018
|
I'm happy for this to go out as a v0.5.x. |
|
Likewise happy for it to be in 0.5.x. |
korken89
previously approved these changes
Oct 28, 2018
adamgreig
previously requested changes
Oct 29, 2018
|
@rust-embedded/cortex-m I've fixed the failing build; please re-review. |
|
triage: this has 4 approvals (majority). Changing labels to decision-accepted and S-waiting-on-review. |
korken89
previously approved these changes
Nov 13, 2018
|
bors r=korken89 |
so it matches the exception name (`#[exception] fn HardFault(..`)
|
rebased / force pushed to hopefully unstuck bors |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 14, 2018
144: [RFC] rename UserHardFault to HardFault r=therealprof a=japaric so it matches the exception name (`#[exception] fn HardFault(..`) Right now the symbol name of all exception handlers match the name of the function used with the `#[exception]` attribute *except* for `HardFault`, whose symbol name actually is `UserHardFault`. This PR corrects that inconsistency by renaming the `UserHardFault` symbol to `HardFault`, and the `HardFault` symbol to `HardFaultTrampoline`. This change doesn't break compilation or changes functionality but it does soft break GDB scripts that include the command `break UserHardFault` (e.g. the GDB script in cortex-m-quickstart) in the sense that the breakpoint will no longer work. However the rest of the GDB script will continue to work. RFC questions: (a) do we want to do this rename? (b) if the answer is yes, do we want to include this rename in the v0.5.x release, or should we consider it a breaking change and postpone it until v0.6.0? Co-authored-by: Jorge Aparicio <jorge@japaric.io>
Canceled |
|
latest commit should fix the build error |
|
Looks like your rebase got rid of both of my commits, including the one updating the expected error message in the compile-fail test? |
adamgreig
approved these changes
Nov 14, 2018
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 14, 2018
144: [RFC] rename UserHardFault to HardFault r=adamgreig a=japaric so it matches the exception name (`#[exception] fn HardFault(..`) Right now the symbol name of all exception handlers match the name of the function used with the `#[exception]` attribute *except* for `HardFault`, whose symbol name actually is `UserHardFault`. This PR corrects that inconsistency by renaming the `UserHardFault` symbol to `HardFault`, and the `HardFault` symbol to `HardFaultTrampoline`. This change doesn't break compilation or changes functionality but it does soft break GDB scripts that include the command `break UserHardFault` (e.g. the GDB script in cortex-m-quickstart) in the sense that the breakpoint will no longer work. However the rest of the GDB script will continue to work. RFC questions: (a) do we want to do this rename? (b) if the answer is yes, do we want to include this rename in the v0.5.x release, or should we consider it a breaking change and postpone it until v0.6.0? Co-authored-by: Jorge Aparicio <jorge@japaric.io>
Build succeeded |
|
Hey guys, this seems to have broken the book because of how Semver versioning works: So, the question is should the version of cortext-m-rt have been bumped to 1.0.0 for this as it broke the book? Also, should I re-open that issue? |
bors bot
added a commit
to rust-embedded/book
that referenced
this pull request
Jan 22, 2019
117: Update the references of UserHardFault, which was renamed to HardFault r=korken89 a=sstelfox This updates the book to match the [renamed symbol](rust-embedded/cortex-m-rt#144) and my [associated PR](rust-embedded/cortex-m-quickstart#64) updating the quickstart repository. Co-authored-by: Sam Stelfox <sstelfox@bedroomprogrammers.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so it matches the exception name (
#[exception] fn HardFault(..)Right now the symbol name of all exception handlers match the name of the
function used with the
#[exception]attribute except forHardFault, whosesymbol name actually is
UserHardFault.This PR corrects that inconsistency by renaming the
UserHardFaultsymbol toHardFault, and theHardFaultsymbol toHardFaultTrampoline.This change doesn't break compilation or changes functionality but it does soft
break GDB scripts that include the command
break UserHardFault(e.g. the GDBscript in cortex-m-quickstart) in the sense that the breakpoint will no longer
work. However the rest of the GDB script will continue to work.
RFC questions: (a) do we want to do this rename? (b) if the answer is yes, do we
want to include this rename in the v0.5.x release, or should we consider it a
breaking change and postpone it until v0.6.0?