Skip to content
This repository was archived by the owner on Dec 2, 2020. It is now read-only.

Clean up doctests to make cargo test work #47

Merged
merged 1 commit into from
Nov 22, 2019
Merged

Clean up doctests to make cargo test work #47

merged 1 commit into from
Nov 22, 2019

Conversation

@jonas-schievink
Copy link
Contributor

@jonas-schievink jonas-schievink commented Nov 22, 2019

Fixes compilation, removes unnecessary extern crates, and adds no_run to all doctests to ensure they build without running them.

@jonas-schievink jonas-schievink requested a review from a team as a code owner November 22, 2019 13:55
@rust-highfive
Copy link

rust-highfive commented Nov 22, 2019

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @therealprof (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

therealprof
therealprof approved these changes Nov 22, 2019
View reviewed changes
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@therealprof
Copy link
Contributor

therealprof commented Nov 22, 2019

bors r+

bors bot added a commit that referenced this pull request Nov 22, 2019
@bors @jonas-schievink
Merge #47
7a961f0 
47: Clean up doctests to make `cargo test` work r=therealprof a=jonas-schievink

Fixes compilation, removes unnecessary `extern crate`s, and adds `no_run` to all doctests to ensure they build without running them.

Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
@bors
Copy link
Contributor

bors bot commented Nov 22, 2019

Build succeeded

@bors bors bot merged commit 3d5d10a into rust-embedded:master Nov 22, 2019
@jonas-schievink jonas-schievink deleted the doctest-cleanup branch November 22, 2019 14:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@therealprof therealprof therealprof approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@therealprof therealprof

Labels

S-waiting-on-review T-cortex-m

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonas-schievink @rust-highfive @therealprof