Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requirements: USB cables need data transfer #201

Merged
merged 1 commit into from Jan 13, 2020

Conversation

phansch
Copy link
Contributor

@phansch phansch commented Jan 13, 2020

I was getting started with the discovery book and still had two old
unmarked Mini USB cables laying around. Unfortunately none of them
were working.

I don't know too much about the USB standards, but one reason
may be that these cables only support charging without data transfer.

I think it would be good to mention this here, if people go out and buy
new cables.

I was getting started with the discovery book and still had two old
unmarked Mini USB cables laying around. Unfortunately none of them
were working.

To be fair, I don't know too much about the USB standards, but one reason
may be that these cables only support charging without data transfer.

I think it would be good to mention this here, if people go out and buy
new cables.
@rust-highfive
Copy link

@rust-highfive rust-highfive commented Jan 13, 2020

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @therealprof (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added S-waiting-on-review T-resources labels Jan 13, 2020
Copy link
Contributor

@therealprof therealprof left a comment

Good point, thanks!

@therealprof
Copy link
Contributor

@therealprof therealprof commented Jan 13, 2020

bors r+

bors bot added a commit that referenced this issue Jan 13, 2020
201: Requirements: USB cables need data transfer r=therealprof a=phansch

I was getting started with the discovery book and still had two old
unmarked Mini USB cables laying around. Unfortunately none of them
were working.

I don't know too much about the USB standards, but one reason
may be that these cables only support charging without data transfer.

I think it would be good to mention this here, if people go out and buy
new cables.

Co-authored-by: Philipp Hansch <dev@phansch.net>
@bors
Copy link
Contributor

@bors bors bot commented Jan 13, 2020

Build succeeded

@bors bors bot merged commit d5b6405 into rust-embedded:master Jan 13, 2020
2 checks passed
@phansch phansch deleted the data_transfer branch Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review T-resources
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants