Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't require ParitalEq to the Item of DedupBy #397

merged 1 commit into from Jan 14, 2020


Copy link

@KeenS KeenS commented Jan 10, 2020

PartialEq is't needed because dedup_pred take its place.

Copy link

jswrenn commented Jan 14, 2020


bors r+

@jswrenn jswrenn added this to the next milestone Jan 14, 2020
bors bot added a commit that referenced this pull request Jan 14, 2020
391: Simplify `Clone` implementations r=jswrenn a=phimuemue

Use a macro `clone_fields`, similar to `debug_fmt_fields`.

I replaced existing implementations of `clone_fields` and simplified the macro's parameters.

397: don't require ParitalEq to the Item of DedupBy r=jswrenn a=KeenS

`PartialEq` is't needed because `dedup_pred` take its place.

Co-authored-by: philipp <>
Co-authored-by: κeen <>
Copy link

bors bot commented Jan 14, 2020

Build succeeded

@bors bors bot merged commit 31c3544 into rust-itertools:master Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants