Position max, min and minmax methods #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The max functions use Iterator::max_by, while the min functions use Iterator::min_by.
The implementation uses minmax::minmax_impl rather than Itertools::minmax_by, so that the comparison constraint is relaxed to PartialOrd, just like for the minmax functions.
jswrenn
reviewed
Feb 29, 2020
jswrenn
reviewed
Feb 29, 2020
jswrenn
reviewed
Feb 29, 2020
Co-Authored-By: Jack Wrenn <johnswrenn@gmail.com>
|
Thanks for the contribution! bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The following nine methods are provided:
position_max,position_max_by_key,position_max_by; returnOption<usize>position_min,position_min_by_key,position_min_by; returnOption<usize>position_minmax,position_minmax_by_key,position_minmax_by; returnMinMaxResult<usize>The
position_maxandposition_minmethods are implemented usingIterator::enumerateandIterator::max_by/min_by.The
position_minmaxmethods are implemented usingIterator::enumerateandminmax::minmax_implrather thanItertools::minmax_by, so that the comparison constraint can be relaxed fromOrdtoPartialOrd, just like for theminmaxmethods.Closes #410.