Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

if use_std is enabled, also enable either/use_std #628

Merged
merged 1 commit into from Jul 5, 2022
Merged

if use_std is enabled, also enable either/use_std #628

merged 1 commit into from Jul 5, 2022

Conversation

sunshowers
Copy link
Contributor

@sunshowers sunshowers commented Jul 2, 2022 •
edited

I've been using either through itertools, and I'd love to have either/use_std enabled if use_std is enabled.

phimuemue
phimuemue approved these changes Jul 3, 2022
View reviewed changes
Copy link
Member

@phimuemue phimuemue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, I am (sadly) no expert on this, but after skimming the docs, this looks very reasonable to me.

@jswrenn You're usually good at judging these things. Do you have objections?

@jswrenn
Copy link
Member

jswrenn commented Jul 5, 2022

This sounds fine to me!

bors r+

@jswrenn jswrenn added this to the next milestone Jul 5, 2022
@bors
Copy link
Contributor

bors bot commented Jul 5, 2022

Build succeeded:

@bors bors bot merged commit deae58e into rust-itertools:master Jul 5, 2022
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phimuemue phimuemue phimuemue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
next
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sunshowers @jswrenn @phimuemue