Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added body to free::zip's doc example #632

Merged
merged 2 commits into from Jul 10, 2022

Conversation

JoelMon
Copy link
Contributor

@JoelMon JoelMon commented Jul 8, 2022

Added body to the code example in the docs for free::zip. The code body added uses two types to make it obvious how zip functions.

Added body to the code example in the docs for free::zip.
The code body added uses two types to make it obvious how `zip`
functions.
@JoelMon JoelMon changed the title Added body to free::zip Added body to free::zip's doc example Jul 8, 2022
@phimuemue
Copy link
Member

Hi there, thank you. I think we'd be willing to accept this, but could you undo all the formatting changes? (It may break other PRs and makes the review difficult.)

@JoelMon
Copy link
Contributor Author

JoelMon commented Jul 9, 2022

Hi there, thank you. I think we'd be willing to accept this, but could you undo all the formatting changes? (It may break other PRs and makes the review difficult.)

Sure, I'll resubmit soon.

BTW, would changes to the other examples in the docstrings of this nature be welcomed?

@phimuemue
Copy link
Member

phimuemue commented Jul 10, 2022

Thanks. If documentation is unclear or inconsistent, improvements are highly welcome.

bors r+ squash

@bors
Copy link
Contributor

bors bot commented Jul 10, 2022

Build succeeded:

@bors bors bot merged commit 7a27408 into rust-itertools:master Jul 10, 2022
4 checks passed
@JoelMon JoelMon deleted the zip_docstring branch Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants