Improved docstrings for free::chain
#634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottmcm
reviewed
Jul 11, 2022
src/free.rs
Outdated
| @@ -128,16 +128,25 @@ pub fn zip<I, J>(i: I, j: J) -> Zip<I::IntoIter, J::IntoIter> | |||
| i.into_iter().zip(j) | |||
| } | |||
|
|
|||
| /// Create an iterator that first iterates `i` and then `j`. | |||
| /// `chain()` returns the result of combining the _first_ | |||
There was a problem hiding this comment.
fix: As in #633 (comment), this is not just about https://doc.rust-lang.org/nightly/std/primitive.array.htmls, so shouldn't be written this way.
|
@scottmcm: std::iter::chain this means that this function was also stabilized in std, right? |
phimuemue
reviewed
Aug 25, 2022
JoelMon
force-pushed
the
chain-docstring
branch
2 times, most recently
from
94326f3
to
860f239
Compare
|
I think I finally got this git squashing, force pushing stuff down. It's about time. |
phimuemue
requested changes
Aug 25, 2022
JoelMon
force-pushed
the
chain-docstring
branch
from
860f239
to
520765c
Compare
|
@phimuemue, would you be able to take a look at #633 as well? |
|
Thanks a bunch! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Improved the description of the function and added example.