Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upConsider moving from master/slave terminology #2
Comments
This comment has been minimized.
This comment has been minimized.
steveklabnik
commented
Dec 16, 2014
|
Very, very +1 (and |
This comment has been minimized.
This comment has been minimized.
|
'master' and 'slave' are the buildbot terminology. |
This comment has been minimized.
This comment has been minimized.
|
Yeah, that would be tricky. You can always fork Buildbot and hope a simple text replacement would work |
This comment has been minimized.
This comment has been minimized.
tbu-
commented
Feb 4, 2015
|
@steveklabnik Primary/replica doesn't seem to fit, as there's a controller (the current "master") which completely controls the other instances (the current "slaves"), i.e. they're not replicas of the primary. |
This comment has been minimized.
This comment has been minimized.
|
@tbu- What about leader/follower? |
This comment has been minimized.
This comment has been minimized.
tbu-
commented
Feb 4, 2015
|
That sounds better. |
This comment has been minimized.
This comment has been minimized.
trevrosen
commented
Feb 4, 2015
|
I think "leader/follower" works as a pretty much universal replacement for "master/slave". I don't do any Rust at work, but we've started to use this nomenclature for multi-server environments there. |
This comment has been minimized.
This comment has been minimized.
eevee
commented
Feb 4, 2015
|
uwsgi uses emperor/vassal for some similar feature. "peon" is a great word too. but then i'm inclined towards colorful names :) |
This comment has been minimized.
This comment has been minimized.
tonylukasavage
commented
Feb 4, 2015
|
leader/follower is pretty popular among projects making this particular change. |
This comment has been minimized.
This comment has been minimized.
samphippen
commented
Feb 4, 2015
|
@steveklabnik leader/follower seems correct in this case for me. |
This comment has been minimized.
This comment has been minimized.
coderanger
commented
Feb 4, 2015
|
For CI stuff in the past I've used "server/worker" or "server/builder". |
This comment has been minimized.
This comment has been minimized.
jedahan
commented
Feb 4, 2015
|
leader/follower seems more general than leader/builder though I like both |
This comment has been minimized.
This comment has been minimized.
joneslee85
commented
Feb 4, 2015
|
Oh my, please check django/django#2692 |
This comment has been minimized.
This comment has been minimized.
alex
commented
Feb 4, 2015
|
coordinator/worker is probably what I'd use if I were building a CI system. |
This comment has been minimized.
This comment has been minimized.
effigies
commented
Feb 4, 2015
|
Would suggest controller/worker, but +1 to coordinator/worker, too. |
This comment has been minimized.
This comment has been minimized.
timplunkett
commented
Feb 4, 2015
|
Drupal decided on using |
This comment has been minimized.
This comment has been minimized.
alex
commented
Feb 4, 2015
|
A build system's naming scheme isn't describing the same thing as a On Wed, Feb 4, 2015 at 3:25 PM, Tim Plunkett notifications@github.com
"I disapprove of what you say, but I will defend to the death your right to |
This comment has been minimized.
This comment has been minimized.
tomburns
commented
Feb 4, 2015
|
+1 for leader / follower, given the context. |
This comment has been minimized.
This comment has been minimized.
jjjjw
commented
Feb 4, 2015
|
|
This comment has been minimized.
This comment has been minimized.
reaperhulk
commented
Feb 4, 2015
|
http://trac.buildbot.net/ticket/2340 may also be of interest. |
This comment has been minimized.
This comment has been minimized.
mikeedwards
commented
Feb 4, 2015
|
primary/secondary? That's sort of what mongo does: Primary and replica would work, too, but that might be too specific in terms of function of the "non-primary" machine. Secondary is nicely general, if that matters. |
This comment has been minimized.
This comment has been minimized.
tbu-
commented
Feb 4, 2015
|
@zjjw Your terminology doesn't quite fit, it might fit for databases, but not for build servers. server/worker might fit. |
This comment has been minimized.
This comment has been minimized.
|
@reaperhulk I was in the process of writing a comment there when you posted the link |
This comment has been minimized.
This comment has been minimized.
tomjakubowski
commented
Feb 4, 2015
|
We should avoid using "leader" in upper case or any other context where it could be construed as a title. |
This comment has been minimized.
This comment has been minimized.
kamalmarhubi
commented
Feb 4, 2015
|
slave -> worker above the rest of the suggestions. Perhaps master is all right with that change, trying to decide for myself. For the master:
Edit: ha! Marx's comments on the buildbot ticket are my exact potential issue with master / worker. |
cllns
changed the title
Consider moving from master/slave
Consider moving from master/slave terminology
Feb 4, 2015
This comment has been minimized.
This comment has been minimized.
colingourlay
commented
Feb 5, 2015
|
I'm throwing in |
This comment has been minimized.
This comment has been minimized.
O-I
commented
Feb 5, 2015
|
I think If it didn't make things even more confusing, I'd suggest something like |
This comment has been minimized.
This comment has been minimized.
locks
commented
Feb 5, 2015
|
CouchDB also switched to primary / replica, if I remember correctly: https://issues.apache.org/jira/browse/COUCHDB-2248 |
This comment has been minimized.
This comment has been minimized.
crazymykl
commented
Feb 5, 2015
|
Although |
This comment has been minimized.
This comment has been minimized.
Manishearth
commented
Feb 5, 2015
|
I prefer |
This comment has been minimized.
This comment has been minimized.
lukemayes
commented
Feb 5, 2015
|
@tbi- describing the current "master" as a controller made me think controller/drone or controller/worker might be good. |
This comment has been minimized.
This comment has been minimized.
tomjakubowski
commented
Feb 5, 2015
|
"Drone" is equally problematic in parts of the world ravaged by US military intervention. |
This comment has been minimized.
This comment has been minimized.
steveklabnik
commented
Feb 5, 2015
|
Thank you everyone for your suggestions. Given that we're not a database, I agree that
If upstream ends up rejecting this, we can re-open and see what we can do, but for now, dealing with them is the correct course of action. |
steveklabnik
closed this
Feb 5, 2015
This comment has been minimized.
This comment has been minimized.
dhuseby
commented
Mar 3, 2015
|
How about "gun" and "shovel"? "You see in this world there's two kinds of people, my friend. Those with loaded guns, and those who dig. You dig." |
cllns commentedDec 16, 2014
This seems like an internal tool, but it might be a good idea to change from 'master/slave' to something less problematic.
I'm not familiar with this tool, but
primary/replicamight work. (or leader/follower)@steveklabnik @brson, thoughts?