Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upBuild and release aarch64 android binaries. #103
Conversation
rust-highfive
assigned
brson
May 24, 2016
This comment has been minimized.
This comment has been minimized.
rust-highfive
commented
May 24, 2016
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
This comment has been minimized.
This comment has been minimized.
|
Thanks @pietro! I'm finishing up running some tests locally and I should hopefully ship this soon to production. |
alexcrichton
merged commit 4676d30
into
rust-lang-deprecated:master
May 24, 2016
This comment has been minimized.
This comment has been minimized.
|
Thank you @alexcrichton without your pointers I'd be lost on master.cfg. |
pietro commentedMay 24, 2016
Adding Android Aarch64 to the buildbots was discussed on https://internals.rust-lang.org/t/suggestion-make-real-world-tier-1-platforms-at-least-tier-2/3492
Also e5ac28a has the commit log "Build and release i686+aarch64 android binaries" but it doesn't add Aarch64.