Skip to content
This repository has been archived by the owner. It is now read-only.

Add a new benchmark, tuple-stress. #23

Merged
merged 1 commit into from Nov 23, 2016

Conversation

@nnethercote
Copy link
Contributor

@nnethercote nnethercote commented Nov 22, 2016

This benchmark stresses the compiler in interesting ways and I think it's worth including.

The name follows existing precedent even though I don't much like that precedent, because it results in long names with common prefixes that are a pain to tab-complete :(

The time to compile with a trunk rust is 4.1s on my machine.

r? @Mark-Simulacrum

@Mark-Simulacrum
Copy link
Contributor

@Mark-Simulacrum Mark-Simulacrum commented Nov 23, 2016

I don't believe the precedent makes much sense either; I think renaming this to something more like "big array of tuples" (though possibly not "big" since IIRC there's another benchmark with that name). We can include the issue information and other metadata as comments in the makefile or in the main source; or introduce a README in each directory documenting why that test is there and what it's intended to test. It's possible we can later convert some of that information to something shown on the site itself, too.

@nnethercote
Copy link
Contributor Author

@nnethercote nnethercote commented Nov 23, 2016

Name ideas: "ost-stress", "tuple-stress"?

@Mark-Simulacrum
Copy link
Contributor

@Mark-Simulacrum Mark-Simulacrum commented Nov 23, 2016

"tuple-stress" sounds good to me. @nrc What do you think?

@nrc
Copy link
Collaborator

@nrc nrc commented Nov 23, 2016

+1 for avoiding issue... prefixes. big_array_of_tuples would be fine by itself, or tuple_stress is fine too

@nnethercote nnethercote force-pushed the nnethercote:add-ost branch from 62e38d5 to 790ef09 Nov 23, 2016
@nnethercote
Copy link
Contributor Author

@nnethercote nnethercote commented Nov 23, 2016

Updated to "tuple-stress".

@nnethercote nnethercote changed the title Add a new benchmark, issue36799-big-array-of-tuples. Add a new benchmark, tuple-stress. Nov 23, 2016
@Mark-Simulacrum
Copy link
Contributor

@Mark-Simulacrum Mark-Simulacrum commented Nov 23, 2016

Looks good to me. I can't r+ (no permissions), though.

@nrc nrc merged commit d525abd into rust-lang-deprecated:master Nov 23, 2016
@nnethercote nnethercote deleted the nnethercote:add-ost branch Nov 24, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.