New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new benchmark, tuple-stress. #23

Merged
merged 1 commit into from Nov 23, 2016

Conversation

Projects
None yet
3 participants
@nnethercote
Contributor

nnethercote commented Nov 22, 2016

This benchmark stresses the compiler in interesting ways and I think it's worth including.

The name follows existing precedent even though I don't much like that precedent, because it results in long names with common prefixes that are a pain to tab-complete :(

The time to compile with a trunk rust is 4.1s on my machine.

r? @Mark-Simulacrum

@Mark-Simulacrum

This comment has been minimized.

Show comment
Hide comment
@Mark-Simulacrum

Mark-Simulacrum Nov 23, 2016

Contributor

I don't believe the precedent makes much sense either; I think renaming this to something more like "big array of tuples" (though possibly not "big" since IIRC there's another benchmark with that name). We can include the issue information and other metadata as comments in the makefile or in the main source; or introduce a README in each directory documenting why that test is there and what it's intended to test. It's possible we can later convert some of that information to something shown on the site itself, too.

Contributor

Mark-Simulacrum commented Nov 23, 2016

I don't believe the precedent makes much sense either; I think renaming this to something more like "big array of tuples" (though possibly not "big" since IIRC there's another benchmark with that name). We can include the issue information and other metadata as comments in the makefile or in the main source; or introduce a README in each directory documenting why that test is there and what it's intended to test. It's possible we can later convert some of that information to something shown on the site itself, too.

@nnethercote

This comment has been minimized.

Show comment
Hide comment
@nnethercote

nnethercote Nov 23, 2016

Contributor

Name ideas: "ost-stress", "tuple-stress"?

Contributor

nnethercote commented Nov 23, 2016

Name ideas: "ost-stress", "tuple-stress"?

@Mark-Simulacrum

This comment has been minimized.

Show comment
Hide comment
@Mark-Simulacrum

Mark-Simulacrum Nov 23, 2016

Contributor

"tuple-stress" sounds good to me. @nrc What do you think?

Contributor

Mark-Simulacrum commented Nov 23, 2016

"tuple-stress" sounds good to me. @nrc What do you think?

@nrc

This comment has been minimized.

Show comment
Hide comment
@nrc

nrc Nov 23, 2016

Collaborator

+1 for avoiding issue... prefixes. big_array_of_tuples would be fine by itself, or tuple_stress is fine too

Collaborator

nrc commented Nov 23, 2016

+1 for avoiding issue... prefixes. big_array_of_tuples would be fine by itself, or tuple_stress is fine too

@nnethercote

This comment has been minimized.

Show comment
Hide comment
@nnethercote

nnethercote Nov 23, 2016

Contributor

Updated to "tuple-stress".

Contributor

nnethercote commented Nov 23, 2016

Updated to "tuple-stress".

@nnethercote nnethercote changed the title from Add a new benchmark, issue36799-big-array-of-tuples. to Add a new benchmark, tuple-stress. Nov 23, 2016

@Mark-Simulacrum

This comment has been minimized.

Show comment
Hide comment
@Mark-Simulacrum

Mark-Simulacrum Nov 23, 2016

Contributor

Looks good to me. I can't r+ (no permissions), though.

Contributor

Mark-Simulacrum commented Nov 23, 2016

Looks good to me. I can't r+ (no permissions), though.

@nrc nrc merged commit d525abd into rust-lang-deprecated:master Nov 23, 2016

@nnethercote nnethercote deleted the nnethercote:add-ost branch Nov 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment