This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upMake rustup.sh interactive and not require sudo #12
Conversation
brson
added some commits
Apr 30, 2015
This comment has been minimized.
This comment has been minimized.
|
r? @alexcrichton but we might wait a day or two for comment from https://internals.rust-lang.org/t/what-changes-are-necessary-to-make-rustup-sh-handle-sudo-itself/1948/5 |
This comment has been minimized.
This comment has been minimized.
|
r+ from me, but I agree on waiting for a few comments |
This comment has been minimized.
This comment has been minimized.
|
I like the welcome message |
This comment has been minimized.
This comment has been minimized.
|
I'm going to merge this, but not deploy until I've got a patch for travis in. |
brson
added a commit
that referenced
this pull request
May 1, 2015
brson
merged commit 404d142
into
rust-lang-deprecated:master
May 1, 2015
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
This comment has been minimized.
This comment has been minimized.
|
Here's the patch to travis travis-ci/travis-build#443 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
brson commentedApr 30, 2015
This changes rustup in the following ways.
The basic welcome message looks like this: