Skip to content
This repository has been archived by the owner. It is now read-only.

Make rustup.sh interactive and not require sudo #12

Merged
merged 5 commits into from May 1, 2015

Conversation

Projects
None yet
3 participants
@brson
Copy link
Contributor

brson commented Apr 30, 2015

This changes rustup in the following ways.

  • rustup runs 'sudo' to do the install unless --disable-sudo is passed
  • it displays an initial welcome message that explains what is going to happen, including running sudo, then requires confirmation to proceed
  • the -y flag disables the welcome message
  • adds some ugly metadata upgrade code to deal with old root-owned .rustup directories
  • warns if running as root

The basic welcome message looks like this:

Welcome to Rust.

This script will download the Rust compiler and its package manager, Cargo, and
install them to /usr/local. You may install elsewhere by running this script
with the --prefix=<path> option.

The installer will run under 'sudo' and may ask you for your password. If you do
not want the script to run 'sudo' then pass this script the --disable-sudo flag.

You may uninstall later by running /usr/local/lib/rustlib/uninstall.sh,
or by running this script again with the --uninstall flag.

Continue? (y/N)
@brson

This comment has been minimized.

Copy link
Contributor Author

brson commented Apr 30, 2015

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Apr 30, 2015

r+ from me, but I agree on waiting for a few comments

@steveklabnik

This comment has been minimized.

Copy link
Contributor

steveklabnik commented May 1, 2015

I like the welcome message 👍

@brson

This comment has been minimized.

Copy link
Contributor Author

brson commented May 1, 2015

I'm going to merge this, but not deploy until I've got a patch for travis in.

brson added a commit that referenced this pull request May 1, 2015

Merge pull request #12 from brson/next
Make rustup.sh interactive and not require sudo

@brson brson merged commit 404d142 into rust-lang-deprecated:master May 1, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@brson

This comment has been minimized.

Copy link
Contributor Author

brson commented May 1, 2015

Here's the patch to travis travis-ci/travis-build#443

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.