Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain that it's ok for build scripts and proc macros to panic #104

Closed
brson opened this Issue Jul 13, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@brson
Copy link
Contributor

brson commented Jul 13, 2017

In the section about not panicking, we need to also explain that there are cases where panicking is the accepted strategy. In most build scripts and crates that are intended to be used primarily in build scripts, errors result in panicks.

Explain this, but also that it's important to provide try_ methods if it's possible the code won't be used at build time. Also that the panic messages must be awesome.

@dtolnay

This comment has been minimized.

Copy link
Member

dtolnay commented Oct 30, 2017

I don't think we have or need a section about not panicking. This is sufficiently covered by To panic! or Not To panic!.

@dtolnay dtolnay closed this Oct 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.