Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upExplain that it's ok for build scripts and proc macros to panic #104
Comments
dtolnay
added
the
clarification
label
Sep 18, 2017
dtolnay
added
the
hacktoberfest
label
Oct 1, 2017
This comment has been minimized.
This comment has been minimized.
|
I don't think we have or need a section about not panicking. This is sufficiently covered by To panic! or Not To panic!. |
dtolnay
closed this
Oct 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
brson commentedJul 13, 2017
In the section about not panicking, we need to also explain that there are cases where panicking is the accepted strategy. In most build scripts and crates that are intended to be used primarily in build scripts, errors result in panicks.
Explain this, but also that it's important to provide
try_methods if it's possible the code won't be used at build time. Also that the panic messages must be awesome.