Skip to content

/api-guidelines

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to decide whether to provide Serde impls #12

Closed
dtolnay opened this Issue Apr 4, 2017 · 3 comments

Comments

Assignees
No one assigned
Labels
clarification hacktoberfest important
Projects
None yet
Milestone
No milestone
2 participants
@dtolnay @brson
@dtolnay
Copy link
Member

dtolnay commented Apr 4, 2017 •
edited

Currently the only guideline is:

Most types should implement serde's Serialize, Deserialize (C-SERDE)

Of the crates that the libs team has covered so far (byteorder, bitflags, tempdir, flate2) we decided that none need Serde impls. The guideline should be rephrased or clarified to incorporate our reasoning.
@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor

brson commented Jun 30, 2017

Add some more color here.

@brson brson added the important label Jun 30, 2017

@dtolnay dtolnay referenced this issue Jun 30, 2017

Closed

Expand c-serde guideline with more motivations for implementing traits #64

@dtolnay

This comment has been minimized.

Sign in to view
Copy link
Member Author

dtolnay commented Jun 30, 2017

See #64 for a particular example.

@dtolnay dtolnay added the clarification label Sep 18, 2017

@dtolnay dtolnay added the hacktoberfest label Oct 1, 2017

@dtolnay

This comment has been minimized.

Sign in to view
Copy link
Member Author

dtolnay commented Oct 25, 2017

I added more color in 5b64a7b.

@dtolnay dtolnay closed this Oct 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.