Skip to content

/api-guidelines

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guideline updates based on the reqwest evaluation #62

Closed
dtolnay opened this Issue May 16, 2017 · 1 comment

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@dtolnay @KodrAus @brson
@dtolnay
Copy link
Member

dtolnay commented May 16, 2017 •
edited

What lessons can we learn from reqwest that will be broadly applicable to other crates? Please leave a comment with your ideas!

Crate evaluation thread on internals.rust-lang.org
@KodrAus

This comment has been minimized.

Sign in to view
Copy link
Collaborator

KodrAus commented May 19, 2017

A few things I like about reqwests design so far:

  • Explicitly ensuring certain types implement traits so they don't accidentally regress
  • The approach to error handling is quite nice. Errors are opaque, so tweaking them isn't always a breaking change and they contain extra useful information. I think it would be nice if projects like error-chain supported black-box errors of this kind too. Locking down the public API seems like a bit of a prerequisite for a stable release.

@brson brson closed this Jun 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.