Skip to content

/api-guidelines

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand c-serde guideline with more motivations for implementing traits #64

Closed
dtolnay opened this Issue May 18, 2017 · 1 comment

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@dtolnay
@dtolnay
Copy link
Member

dtolnay commented May 18, 2017

In the log review we talked about LogLevel and LogLevelFilter as types you might reasonably want to deserialize from a config file. This doesn't fit into the recommendations in the existing guideline.
@dtolnay

This comment has been minimized.

Sign in to view
Copy link
Member Author

dtolnay commented Jun 30, 2017

We will follow up on this as part of #12.

@dtolnay dtolnay closed this Jun 30, 2017

@dtolnay dtolnay referenced this issue Jun 30, 2017

Closed

How to decide whether to provide Serde impls #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.