Skip to content

/api-guidelines

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guideline for importing macro_rules! macros #68

Closed
alexcrichton opened this Issue May 19, 2017 · 1 comment

Comments

Assignees
No one assigned
Labels
important new guideline
Projects
None yet
Milestone
No milestone
3 participants
@alexcrichton @dtolnay @brson
@alexcrichton
Copy link
Member

alexcrichton commented May 19, 2017

Discussed during the log evaluation, we should have a guideline that each macro is selectively importable via #[macro_use(foo)]. We'll want to document the caveats here (duplication) and some common solutions (deduplication via crate functions)

@dtolnay dtolnay referenced this issue May 24, 2017

Closed

#[macro_use(info)] raise error: macro undefined: 'log!' #54

@brson brson added the important label Jun 30, 2017

@dtolnay dtolnay added the new guideline label Sep 18, 2017

@dtolnay

This comment has been minimized.

Sign in to view
Copy link
Member

dtolnay commented Oct 29, 2017

I no longer believe this guideline would be worthwhile. Macros 1.0 macro_rules are too much of a mess to push for this now. Let's just wait for macros 2.0 to fix this correctly.

@dtolnay dtolnay closed this Oct 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.