Skip to content

/api-guidelines

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guideline for word order #70

Closed
dtolnay opened this Issue May 24, 2017 · 2 comments

Comments

Assignees
No one assigned
Labels
important new guideline
Projects
None yet
Milestone
No milestone
2 participants
@dtolnay @brson
@dtolnay
Copy link
Member

dtolnay commented May 24, 2017

The standard library has:

The log crate has:

  • SetLoggerError (verb-object-error)
  • ShutdownLoggerError (verb-object-error)
  • LevelParseError (object-verb-error) 😿

We should recommend being mindful of consistent word order.

@dtolnay dtolnay referenced this issue May 24, 2017

Closed

Word order of error type names #167

@brson brson added the important label Jun 30, 2017

@dtolnay

This comment has been minimized.

Sign in to view
Copy link
Member Author

dtolnay commented Jun 30, 2017

In log we standardized on verb-object-error.

@dtolnay dtolnay added the new guideline label Sep 18, 2017

@faern faern referenced this issue Oct 3, 2017

Merged

Adjust error resolution in oqs-kex-rpc client #1

@dtolnay

This comment has been minimized.

Sign in to view
Copy link
Member Author

dtolnay commented Oct 29, 2017

Added in 417fe03.

@dtolnay dtolnay closed this Oct 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.