Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capitalization and punctuation of error messages #79

Closed
dtolnay opened this Issue May 29, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@dtolnay
Copy link
Member

dtolnay commented May 29, 2017

Libraries seem to be all over the place. Can we standardize on lowercase with no period at the end?

@dtolnay

This comment has been minimized.

Copy link
Member Author

dtolnay commented Jul 19, 2017

The standard library uses lowercase without trailing punctuation.

"unexpected end of file"

"provided string was not `true` or `false`"

"invalid IP address syntax"

"second time provided was later than self"

"invalid utf-8 sequence of {} bytes from index {}"

"environment variable was not valid unicode: {:?}"

@mehcode

This comment has been minimized.

Copy link

mehcode commented Sep 12, 2017

In line with this, capitalization and punctuation of expect should be discussed. I'm in favor of it being treated the same, however, the std library suggests expect messages should be capitalized while at the same time using lowercase anywhere that I looked.

@dtolnay

This comment has been minimized.

Copy link
Member Author

dtolnay commented Oct 29, 2017

Added in 201d903.

@dtolnay dtolnay closed this Oct 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.