Skip to content

/api-guidelines

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error types should implement std::error::Error #8

Closed
dtolnay opened this Issue Apr 4, 2017 · 2 comments

Comments

Assignees
No one assigned
Labels
important new guideline
Projects
None yet
Milestone
No milestone
2 participants
@dtolnay @brson
@dtolnay
Copy link
Member

dtolnay commented Apr 4, 2017

This allows them to be used as the cause of other errors.

@brson brson added the important label Jun 30, 2017

@dtolnay dtolnay added clarification new guideline and removed clarification labels Sep 18, 2017

@dtolnay

This comment has been minimized.

Sign in to view
Copy link
Member Author

dtolnay commented Sep 18, 2017

I think all three of C-SEND-SYNC-ERR, C-MEANINGFUL-ERR, and this, can be folded into a single guideline covering how to do errors correctly.
@dtolnay

This comment has been minimized.

Sign in to view
Copy link
Member Author

dtolnay commented Oct 25, 2017

I combined these three pieces of error guidance into one guideline in a1b7684.

@dtolnay dtolnay closed this Oct 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.