Skip to content

/api-guidelines

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conventions around into_inner() #9

Closed
dtolnay opened this Issue Apr 4, 2017 · 3 comments

Comments

Assignees
No one assigned
Labels
clarification hacktoberfest important
Projects
None yet
Milestone
No milestone
3 participants
@dtolnay @withoutboats @brson
@dtolnay
Copy link
Member

dtolnay commented Apr 4, 2017

Real-world example: flate2::read::GzEncoder::into_inner.

@brson brson added the important label Jun 30, 2017

@dtolnay dtolnay added the clarification label Sep 18, 2017

@dtolnay dtolnay added the hacktoberfest label Oct 1, 2017

@dtolnay

This comment has been minimized.

Sign in to view
Copy link
Member Author

dtolnay commented Oct 28, 2017

The failure crate uses inner() instead of into_inner() in withoutboats/failure@9ec4e6e. @withoutboats do you think this is a better convention everywhere that currently uses into_inner(), or is there something unique to failure that made inner() better?
@withoutboats

This comment has been minimized.

Sign in to view
Copy link

withoutboats commented Oct 28, 2017

Nope, if the convention is into_inner that would be a better name there!
@dtolnay

This comment has been minimized.

Sign in to view
Copy link
Member Author

dtolnay commented Oct 30, 2017

I documented this convention in 1bd903f.

@dtolnay dtolnay closed this Oct 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.