Skip to content

/api-guidelines

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend that git commit corresponding to each release is tagged #91

Closed
dtolnay opened this Issue Jun 3, 2017 · 4 comments

Comments

Assignees
No one assigned
Labels
clarification hacktoberfest
Projects
None yet
Milestone
No milestone
2 participants
@dtolnay @mathstuf
@dtolnay
Copy link
Member

dtolnay commented Jun 3, 2017 •
edited

This is worth mentioning in the C-RELNOTES guideline.

@dtolnay dtolnay added the clarification label Sep 18, 2017

@dtolnay dtolnay added the hacktoberfest label Oct 1, 2017

@dtolnay

This comment has been minimized.

Sign in to view
Copy link
Member Author

dtolnay commented Oct 29, 2017

Added in b5be841.

@dtolnay dtolnay closed this Oct 29, 2017

@mathstuf

This comment has been minimized.

Sign in to view
Copy link
Contributor

mathstuf commented Nov 8, 2017

It is probably best to also recommend using annotated tags for official releases (the -a flag). It should also mention that similar processes should be followed for non-git VCS tools as well.
@dtolnay

This comment has been minimized.

Sign in to view
Copy link
Member Author

dtolnay commented Nov 8, 2017

Thanks for the ideas! I agree. I added -a in ac585b7 and added a note about non-git in df9c5e2. The wording in this guideline isn't great so please send a PR if you can write it more clearly.
@mathstuf

This comment has been minimized.

Sign in to view
Copy link
Contributor

mathstuf commented Nov 8, 2017

Annotated tags are used not just for name and email; PR incoming :) .

@mathstuf mathstuf referenced this issue Nov 8, 2017

Merged

Tagging rewording #143

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.