Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recommend that git commit corresponding to each release is tagged #91

Closed
dtolnay opened this issue Jun 3, 2017 · 4 comments
Closed

Recommend that git commit corresponding to each release is tagged #91

dtolnay opened this issue Jun 3, 2017 · 4 comments
Labels
clarification

Comments

@dtolnay
Copy link
Member

dtolnay commented Jun 3, 2017 •
edited
Loading

This is worth mentioning in the C-RELNOTES guideline.
@dtolnay
Copy link
Member Author

dtolnay commented Oct 29, 2017

Added in b5be841.

@dtolnay dtolnay closed this as completed Oct 29, 2017
@mathstuf
Copy link
Contributor

mathstuf commented Nov 8, 2017

It is probably best to also recommend using annotated tags for official releases (the -a flag). It should also mention that similar processes should be followed for non-git VCS tools as well.

@dtolnay
Copy link
Member Author

dtolnay commented Nov 8, 2017

Thanks for the ideas! I agree. I added -a in ac585b7 and added a note about non-git in df9c5e2. The wording in this guideline isn't great so please send a PR if you can write it more clearly.

@mathstuf
Copy link
Contributor

mathstuf commented Nov 8, 2017

Annotated tags are used not just for name and email; PR incoming :) .

@mathstuf mathstuf mentioned this issue Nov 8, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
clarification
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mathstuf @dtolnay